diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/net/lan91c96.c | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/net/lan91c96.c')
| -rw-r--r-- | drivers/net/lan91c96.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c index 13900f10b1..c2f611144d 100644 --- a/drivers/net/lan91c96.c +++ b/drivers/net/lan91c96.c @@ -114,7 +114,7 @@ . print a warning and set the environment and other globals with the default. . If an EEPROM is present it really should be consulted. */ -static int smc_get_ethaddr(bd_t *bd, struct eth_device *dev); +static int smc_get_ethaddr(struct bd_info *bd, struct eth_device *dev); static int get_rom_mac(struct eth_device *dev, unsigned char *v_rom_mac); /* ------------------------------------------------------------ @@ -471,7 +471,7 @@ static int smc_send_packet(struct eth_device *dev, void *packet, * Set up everything, reset the card, etc .. * */ -static int smc_open(bd_t *bd, struct eth_device *dev) +static int smc_open(struct bd_info *bd, struct eth_device *dev) { int i, err; /* used to set hw ethernet address */ @@ -674,7 +674,7 @@ static void print_packet(byte *buf, int length) } #endif /* SMC_DEBUG > 2 */ -static int lan91c96_init(struct eth_device *dev, bd_t *bd) +static int lan91c96_init(struct eth_device *dev, struct bd_info *bd) { return smc_open(bd, dev); } @@ -701,7 +701,7 @@ static int lan91c96_send(struct eth_device *dev, void *packet, * found, the environment takes precedence. */ -static int smc_get_ethaddr(bd_t *bd, struct eth_device *dev) +static int smc_get_ethaddr(struct bd_info *bd, struct eth_device *dev) { uchar v_mac[6]; |