diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/net/dc2114x.c | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/net/dc2114x.c')
| -rw-r--r-- | drivers/net/dc2114x.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/dc2114x.c b/drivers/net/dc2114x.c index c55358ef83..0cb54e3214 100644 --- a/drivers/net/dc2114x.c +++ b/drivers/net/dc2114x.c @@ -320,7 +320,7 @@ static int write_srom(struct eth_device *dev, u_long ioaddr, int index, return 1; } -static void update_srom(struct eth_device *dev, bd_t *bis) +static void update_srom(struct eth_device *dev, struct bd_info *bis) { static unsigned short eeprom[0x40] = { 0x140b, 0x6610, 0x0000, 0x0000, /* 00 */ @@ -356,7 +356,7 @@ static void update_srom(struct eth_device *dev, bd_t *bis) } #endif /* UPDATE_SROM */ -static void send_setup_frame(struct eth_device *dev, bd_t *bis) +static void send_setup_frame(struct eth_device *dev, struct bd_info *bis) { char setup_frame[SETUP_FRAME_LEN]; char *pa = &setup_frame[0]; @@ -484,7 +484,7 @@ static int dc21x4x_recv(struct eth_device *dev) return length; } -static int dc21x4x_init(struct eth_device *dev, bd_t *bis) +static int dc21x4x_init(struct eth_device *dev, struct bd_info *bis) { int i; int devbusfn = (int)dev->priv; @@ -547,7 +547,7 @@ static void dc21x4x_halt(struct eth_device *dev) pci_write_config_byte(devbusfn, PCI_CFDA_PSM, SLEEP); } -static void read_hw_addr(struct eth_device *dev, bd_t *bis) +static void read_hw_addr(struct eth_device *dev, struct bd_info *bis) { u_short tmp, *p = (u_short *)(&dev->enetaddr[0]); int i, j = 0; @@ -573,7 +573,7 @@ static struct pci_device_id supported[] = { { } }; -int dc21x4x_initialize(bd_t *bis) +int dc21x4x_initialize(struct bd_info *bis) { struct eth_device *dev; unsigned short status; |