diff options
author | Andrew Davis <afd@ti.com> | 2022-10-07 12:11:13 -0500 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2022-10-18 13:40:40 -0400 |
commit | b9add6413d2bcbec281d1a1edeec5c729a576a1b (patch) | |
tree | b1eabcf9922944ccff2f79b9b948eb6b84b917e1 /drivers/dma/ti-edma3.c | |
parent | b8392650462094ed15e123f836daccd7617946a5 (diff) |
dma: Transfer dma_ops should use DMA address types
DMA operations should function on DMA addresses, not virtual addresses.
Although these are usually the same in U-Boot, it is more correct
to be explicit with our types here.
Signed-off-by: Andrew Davis <afd@ti.com>
Diffstat (limited to 'drivers/dma/ti-edma3.c')
-rw-r--r-- | drivers/dma/ti-edma3.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/dma/ti-edma3.c b/drivers/dma/ti-edma3.c index 53dc4e8ce5..1ad3b92dbf 100644 --- a/drivers/dma/ti-edma3.c +++ b/drivers/dma/ti-edma3.c @@ -396,7 +396,7 @@ void qedma3_stop(u32 base, struct edma3_channel_config *cfg) } void __edma3_transfer(unsigned long edma3_base_addr, unsigned int edma_slot_num, - void *dst, void *src, size_t len, size_t s_len) + dma_addr_t dst, dma_addr_t src, size_t len, size_t s_len) { struct edma3_slot_config slot; struct edma3_channel_config edma_channel; @@ -484,7 +484,7 @@ void __edma3_transfer(unsigned long edma3_base_addr, unsigned int edma_slot_num, } void __edma3_fill(unsigned long edma3_base_addr, unsigned int edma_slot_num, - void *dst, u8 val, size_t len) + dma_addr_t dst, u8 val, size_t len) { int xfer_len; int max_xfer = EDMA_FILL_BUFFER_SIZE * 65535; @@ -499,7 +499,7 @@ void __edma3_fill(unsigned long edma3_base_addr, unsigned int edma_slot_num, xfer_len = max_xfer; __edma3_transfer(edma3_base_addr, edma_slot_num, dst, - edma_fill_buffer, xfer_len, + source, xfer_len, EDMA_FILL_BUFFER_SIZE); len -= xfer_len; dst += xfer_len; @@ -517,7 +517,7 @@ void edma3_transfer(unsigned long edma3_base_addr, unsigned int edma_slot_num, dma_addr_t destination = dma_map_single(dst, len, DMA_FROM_DEVICE); dma_addr_t source = dma_map_single(src, len, DMA_TO_DEVICE); - __edma3_transfer(edma3_base_addr, edma_slot_num, dst, src, len, len); + __edma3_transfer(edma3_base_addr, edma_slot_num, destination, source, len, len); /* Clean+Invalidate the areas after, so we can see DMA'd data */ dma_unmap_single(destination, len, DMA_FROM_DEVICE); @@ -530,7 +530,7 @@ void edma3_fill(unsigned long edma3_base_addr, unsigned int edma_slot_num, /* Clean the area, so no writeback into the RAM races with DMA */ dma_addr_t destination = dma_map_single(dst, len, DMA_FROM_DEVICE); - __edma3_fill(edma3_base_addr, edma_slot_num, dst, val, len); + __edma3_fill(edma3_base_addr, edma_slot_num, destination, val, len); /* Clean+Invalidate the area after, so we can see DMA'd data */ dma_unmap_single(destination, len, DMA_FROM_DEVICE); @@ -538,8 +538,8 @@ void edma3_fill(unsigned long edma3_base_addr, unsigned int edma_slot_num, #else -static int ti_edma3_transfer(struct udevice *dev, int direction, void *dst, - void *src, size_t len) +static int ti_edma3_transfer(struct udevice *dev, int direction, + dma_addr_t dst, dma_addr_t src, size_t len) { struct ti_edma3_priv *priv = dev_get_priv(dev); |