aboutsummaryrefslogtreecommitdiff
path: root/drivers/core/device.c
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2021-01-31 08:49:53 -0500
committerTom Rini <trini@konsulko.com>2021-01-31 08:49:53 -0500
commit242ef48ea76ae13ac6357cc50aae01eb7a46bfef (patch)
tree18105866b6063eddcc7ddb0530c002fadc377b3b /drivers/core/device.c
parent76404f86a24aa28efc26a296bf6ab9d697c60b9f (diff)
parentf84eda89e5970ef513fe64ba8e8d977788c44dca (diff)
Merge tag 'dm-pull-30jan21' of https://gitlab.denx.de/u-boot/custodians/u-boot-dm
tpm fixes for coral binman fixes support for symbols in sub-sections support for additional cros_ec commands various minor fixes / tweaks
Diffstat (limited to 'drivers/core/device.c')
-rw-r--r--drivers/core/device.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/core/device.c b/drivers/core/device.c
index aeab3836ed..8629df8def 100644
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -462,6 +462,15 @@ int device_probe(struct udevice *dev)
* continue regardless of the result of pinctrl. Don't process pinctrl
* settings for pinctrl devices since the device may not yet be
* probed.
+ *
+ * This call can produce some non-intuitive results. For example, on an
+ * x86 device where dev is the main PCI bus, the pinctrl device may be
+ * child or grandchild of that bus, meaning that the child will be
+ * probed here. If the child happens to be the P2SB and the pinctrl
+ * device is a child of that, then both the pinctrl and P2SB will be
+ * probed by this call. This works because the DM_FLAG_ACTIVATED flag
+ * is set just above. However, the PCI bus' probe() method and
+ * associated uclass methods have not yet been called.
*/
if (dev->parent && device_get_uclass_id(dev) != UCLASS_PINCTRL)
pinctrl_select_state(dev, "default");