diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /arch/powerpc/cpu/mpc83xx | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/powerpc/cpu/mpc83xx')
-rw-r--r-- | arch/powerpc/cpu/mpc83xx/cpu.c | 4 | ||||
-rw-r--r-- | arch/powerpc/cpu/mpc83xx/fdt.c | 2 | ||||
-rw-r--r-- | arch/powerpc/cpu/mpc83xx/interrupts.c | 2 | ||||
-rw-r--r-- | arch/powerpc/cpu/mpc83xx/pci.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/arch/powerpc/cpu/mpc83xx/cpu.c b/arch/powerpc/cpu/mpc83xx/cpu.c index 49c75a0e50..843f2df649 100644 --- a/arch/powerpc/cpu/mpc83xx/cpu.c +++ b/arch/powerpc/cpu/mpc83xx/cpu.c @@ -184,7 +184,7 @@ void watchdog_reset (void) * Initializes on-chip ethernet controllers. * to override, implement board_eth_init() */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { #if defined(CONFIG_UEC_ETH) uec_standard_init(bis); @@ -201,7 +201,7 @@ int cpu_eth_init(bd_t *bis) * Initializes on-chip MMC controllers. * to override, implement board_mmc_init() */ -int cpu_mmc_init(bd_t *bis) +int cpu_mmc_init(struct bd_info *bis) { #ifdef CONFIG_FSL_ESDHC return fsl_esdhc_mmc_init(bis); diff --git a/arch/powerpc/cpu/mpc83xx/fdt.c b/arch/powerpc/cpu/mpc83xx/fdt.c index 5c685353e1..ebdedb2888 100644 --- a/arch/powerpc/cpu/mpc83xx/fdt.c +++ b/arch/powerpc/cpu/mpc83xx/fdt.c @@ -31,7 +31,7 @@ void fdt_fixup_muram (void *blob) } #endif -void ft_cpu_setup(void *blob, bd_t *bd) +void ft_cpu_setup(void *blob, struct bd_info *bd) { immap_t *immr = (immap_t *)CONFIG_SYS_IMMR; int spridr = immr->sysconf.spridr; diff --git a/arch/powerpc/cpu/mpc83xx/interrupts.c b/arch/powerpc/cpu/mpc83xx/interrupts.c index d04f31df50..05380674dc 100644 --- a/arch/powerpc/cpu/mpc83xx/interrupts.c +++ b/arch/powerpc/cpu/mpc83xx/interrupts.c @@ -72,7 +72,7 @@ void timer_interrupt_cpu (struct pt_regs *regs) * irqinfo - print information about PCI devices */ -void do_irqinfo(struct cmd_tbl *cmdtp, bd_t *bd, int flag, int argc, +void do_irqinfo(struct cmd_tbl *cmdtp, struct bd_info *bd, int flag, int argc, char *const argv[]) { } diff --git a/arch/powerpc/cpu/mpc83xx/pci.c b/arch/powerpc/cpu/mpc83xx/pci.c index f017985ae9..d057cd6351 100644 --- a/arch/powerpc/cpu/mpc83xx/pci.c +++ b/arch/powerpc/cpu/mpc83xx/pci.c @@ -185,7 +185,7 @@ void mpc83xx_pcislave_unlock(int bus) #endif #if defined(CONFIG_OF_LIBFDT) -void ft_pci_setup(void *blob, bd_t *bd) +void ft_pci_setup(void *blob, struct bd_info *bd) { int nodeoffset; int tmp[2]; |