diff options
author | Ming Liu <liu.ming50@gmail.com> | 2021-05-31 09:04:51 +0200 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2021-07-14 16:57:35 -0400 |
commit | 7c39799dec2cafbe631a35d2c17d080e73741db5 (patch) | |
tree | 907923cedc5cb1fb26c136a93f8b21d84f672095 | |
parent | 9c70237f19ab2c9084128b84c491c5e8d102008d (diff) |
tools: image-host: fix wrong return value
The return value '-ENOSPC' of fit_set_timestamp function does not match
the caller fit_image_write_sig's expection which is '-FDT_ERR_NOSPACE'.
Fix it by not calling fit_set_timestamp, but call fdt_setprop instead.
This fixes a following mkimage error:
| Can't write signature for 'signature@1' signature node in
| 'conf@imx6ull-colibri-wifi-eval-v3.dtb' conf node: <unknown error>
| mkimage Can't add hashes to FIT blob: -1
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Tested-by: Igor Opaniuk <igor.opaniuk@foundries.io>
-rw-r--r-- | tools/image-host.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/image-host.c b/tools/image-host.c index 270d36fe45..73095461a7 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -132,8 +132,10 @@ static int fit_image_write_sig(void *fit, int noffset, uint8_t *value, if (!ret) { time_t timestamp = imagetool_get_source_date(cmdname, time(NULL)); + uint32_t t = cpu_to_uimage(timestamp); - ret = fit_set_timestamp(fit, noffset, timestamp); + ret = fdt_setprop(fit, noffset, FIT_TIMESTAMP_PROP, &t, + sizeof(uint32_t)); } if (region_prop && !ret) { uint32_t strdata[2]; |