diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-09-27 14:22:05 +0300 |
|---|---|---|
| committer | Ramon Fried <rfried.dev@gmail.com> | 2021-09-28 18:50:57 +0300 |
| commit | 4df9f5e39fb224a4857c3411b4cbe419e4d339e8 (patch) | |
| tree | b5fe674b0e40c0fa97bd8a360da79bdb335c4b0d | |
| parent | 19ef59f1e098a977272080f5a7321169d8b98f34 (diff) | |
scripts: ensure the cocci script for miiphy_register does not leak the MDIO bus
When mdio_register fails, mdio_free should be called on the mdiodev that
was previously allocated with mdio_alloc.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
| -rw-r--r-- | scripts/coccinelle/net/mdio_register.cocci | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/coccinelle/net/mdio_register.cocci b/scripts/coccinelle/net/mdio_register.cocci index 31a40360f9..7d11281f46 100644 --- a/scripts/coccinelle/net/mdio_register.cocci +++ b/scripts/coccinelle/net/mdio_register.cocci @@ -21,7 +21,7 @@ identifier readfunc, writefunc; + mdiodev->write = writefunc; + + retval = mdio_register(mdiodev); -+ if (retval < 0) return retval; ++ if (retval < 0) { mdio_free(mdiodev); return retval; } @ update_read_sig @ identifier mii_reg.readfunc; |