Fix: error out when packet doesn't fit into buffer

1 files changed, 8 insertions, 2 deletions

diff --git a/src/header.rs b/src/header.rs
index 9a676b2..a97d8d7 100644
--- a/src/header.rs
+++ b/src/header.rs
@@ -228,7 +228,7 @@ impl<'a> Header<'a> {
         code: Code,
         session_id: u16,
     ) -> Result<Header, ParseError> {
-        Self::ensure_minimal_buffer_length(buffer);
+        Self::ensure_minimal_buffer_length(buffer)?;
 
         // set version and type
         buffer[0] = 0x11;
@@ -450,7 +450,7 @@ mod tests {
     }
 
     #[test]
-    fn buffer_less_than_minimal_required_size() {
+    fn buffer_less_than_minimal_required_size_for_parsing() {
         let buffer = &mut [0u8; 4];
         let err = expect_parse_error(buffer);
         assert!(match err {
@@ -460,6 +460,12 @@ mod tests {
     }
 
     #[test]
+    fn buffer_less_than_minimal_required_size_for_creation() {
+        let buffer = &mut [0u8; 4];
+        assert!(Header::create_padi(buffer).is_err());
+    }
+
+    #[test]
     fn invalid_pppoe_version() {
         let buffer = &mut [0u8; 20];
         let err = expect_parse_error(buffer);