Add support for UTF-8 strings on Windows.

Add a routine pcap_init() that initializes pcap, specifying whether
strings should be treated as being in UTF-8 or a local character
encoding.

On UN*Xes, we don't change our behavior based on that setting; if there
is ever an issue with local character encodings *other* than UTF-8, we
can use it.

On Windows, the local character encoding is the local ANSI code page; if
pcap_init() isn't called, or is called with PCAP_CHAR_ENC_LOCAL, strings
are treated as being in the current ANSI code page, as before, otherwise
they're treated as being in UTF-8.  This includes file path names and
error messages.

In addition, if pcap_init() is called, regardless of the options, we
disable pcap_lookupdev(), making it always return NULL, as it retunred
*UTF-16LE* strings (plural!) on Windows NT, and pcap_create() had to
check for UTF-16LE strings to work around that.  That workaround is
unsafe (it will read past the end of the input string if the string is
one ASCII character), and is also disabled if pcap_init() is called.

We also make rpcapd send UTF-8 error message strings over the wire;
sending local code page strings is a Bad Idea, as the client has no idea
what the server's code page is.  (Do not assume the client and server
are necessarily in the same location.)

Fix the capitalization of "Winsock" while we're at it; Microsoft appears
to spell it "Winsock", rather than "WinSock".

1 files changed, 8 insertions, 0 deletions

diff --git a/pcap_lookupdev.3pcap b/pcap_lookupdev.3pcap
index a3807de6..57b76585 100644
--- a/pcap_lookupdev.3pcap
+++ b/pcap_lookupdev.3pcap
@@ -44,6 +44,11 @@ and, if the list it returns is not empty, use the first device in the
 list.  (If the list is empty, there are no devices on which capture is
 possible.)
 .LP
+.B If
+.BR pcap_init (3PCAP)
+.B has been called, this interface always returns
+.BR NULL .
+.LP
 .BR pcap_lookupdev ()
 returns a pointer to a string giving the name of a network device
 suitable for use with
@@ -55,6 +60,9 @@ or with
 and with
 .BR pcap_lookupnet (3PCAP).
 If there is an error,
+or if
+.BR pcap_init (3PCAP)
+has been called,
 .B NULL
 is returned and
 .I errbuf