diff options
| author | Denis Ovsienko <denis@ovsienko.info> | 2021-05-23 15:33:56 +0100 |
|---|---|---|
| committer | Denis Ovsienko <denis@ovsienko.info> | 2021-05-23 15:33:56 +0100 |
| commit | aa4163e6730e1863ce74ac406af0dd1b2f3dbfa2 (patch) | |
| tree | 4f98aa1561b8d39a7caa95c26b401d3e442280ac | |
| parent | accdd71df441fa35dc2620bdca5d073c240ecc64 (diff) | |
Use snprintf() in findalldevstest.c.
Clang 10.0.1 in OpenBSD 6.9 (on MIPS64, although not on AArch64 or
AMD64) emitted a few warnings, which on this occasion did not stand for
an issue. Squelch these anyway by switching to snprintf(). While at it,
clarify the array size using a sizeof().
/usr/bin/ld: Dwarf Error: found dwarf version '0', this reader only
handles version 2 information.
/tmp/findalldevstest-807330.o: In function `main':
findalldevstest.c:(.text+0x6ec): warning: sprintf() is often misused,
please use snprintf()
| -rw-r--r-- | testprogs/findalldevstest.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/testprogs/findalldevstest.c b/testprogs/findalldevstest.c index 092fd045..06293209 100644 --- a/testprogs/findalldevstest.c +++ b/testprogs/findalldevstest.c @@ -321,12 +321,12 @@ static int ifprint(pcap_if_t *d) #define IPTOSBUFFERS 12 static char *iptos(bpf_u_int32 in) { - static char output[IPTOSBUFFERS][3*4+3+1]; + static char output[IPTOSBUFFERS][sizeof("255.255.255.255")]; static short which; u_char *p; p = (u_char *)∈ which = (which + 1 == IPTOSBUFFERS ? 0 : which + 1); - sprintf(output[which], "%d.%d.%d.%d", p[0], p[1], p[2], p[3]); + snprintf(output[which], sizeof(output[which]), "%d.%d.%d.%d", p[0], p[1], p[2], p[3]); return output[which]; } |