From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- include/fdt_support.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'include/fdt_support.h') diff --git a/include/fdt_support.h b/include/fdt_support.h index 2eff311fa4..b1543b534f 100644 --- a/include/fdt_support.h +++ b/include/fdt_support.h @@ -22,9 +22,9 @@ */ int arch_fixup_fdt(void *blob); -void ft_cpu_setup(void *blob, bd_t *bd); +void ft_cpu_setup(void *blob, struct bd_info *bd); -void ft_pci_setup(void *blob, bd_t *bd); +void ft_pci_setup(void *blob, struct bd_info *bd); u32 fdt_getprop_u32_default_node(const void *fdt, int off, int cell, const char *prop, const u32 dflt); @@ -137,9 +137,9 @@ void fdt_fixup_qe_firmware(void *fdt); int fdt_fixup_display(void *blob, const char *path, const char *display); #if defined(CONFIG_USB_EHCI_FSL) || defined(CONFIG_USB_XHCI_FSL) -void fsl_fdt_fixup_dr_usb(void *blob, bd_t *bd); +void fsl_fdt_fixup_dr_usb(void *blob, struct bd_info *bd); #else -static inline void fsl_fdt_fixup_dr_usb(void *blob, bd_t *bd) {} +static inline void fsl_fdt_fixup_dr_usb(void *blob, struct bd_info *bd) {} #endif /* defined(CONFIG_USB_EHCI_FSL) || defined(CONFIG_USB_XHCI_FSL) */ #if defined(CONFIG_SYS_FSL_SEC_COMPAT) @@ -183,7 +183,7 @@ int fdt_find_or_add_subnode(void *fdt, int parentoffset, const char *name); * @param bd_t Pointer to board data * @return 0 if ok, or -FDT_ERR_... on error */ -int ft_board_setup(void *blob, bd_t *bd); +int ft_board_setup(void *blob, struct bd_info *bd); /* * The keystone2 SOC requires all 32 bit aliased addresses to be converted @@ -191,9 +191,9 @@ int ft_board_setup(void *blob, bd_t *bd); * are added or modified by the image_setup_libfdt(). The ft_board_setup_ex() * called at the end of the image_setup_libfdt() is to do that convertion. */ -void ft_board_setup_ex(void *blob, bd_t *bd); -void ft_cpu_setup(void *blob, bd_t *bd); -void ft_pci_setup(void *blob, bd_t *bd); +void ft_board_setup_ex(void *blob, struct bd_info *bd); +void ft_cpu_setup(void *blob, struct bd_info *bd); +void ft_pci_setup(void *blob, struct bd_info *bd); /** * Add system-specific data to the FDT before booting the OS. @@ -205,7 +205,7 @@ void ft_pci_setup(void *blob, bd_t *bd); * @param bd_t Pointer to board data * @return 0 if ok, or -FDT_ERR_... on error */ -int ft_system_setup(void *blob, bd_t *bd); +int ft_system_setup(void *blob, struct bd_info *bd); void set_working_fdt_addr(ulong addr); -- cgit v1.2.3