From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- drivers/net/uli526x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers/net/uli526x.c') diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c index cfdd1137be..3191868cae 100644 --- a/drivers/net/uli526x.c +++ b/drivers/net/uli526x.c @@ -184,7 +184,7 @@ static void uli526x_init(struct eth_device *); static void uli526x_set_phyxcer(struct uli526x_board_info *); -static int uli526x_init_one(struct eth_device *, bd_t *); +static int uli526x_init_one(struct eth_device *, struct bd_info *); static void uli526x_disable(struct eth_device *); static void set_mac_addr(struct eth_device *); @@ -200,7 +200,7 @@ static struct pci_device_id uli526x_pci_tbl[] = { * Search ULI526X board, register it */ -int uli526x_initialize(bd_t *bis) +int uli526x_initialize(struct bd_info *bis) { pci_dev_t devno; int card_number = 0; @@ -255,7 +255,7 @@ int uli526x_initialize(bd_t *bis) return card_number; } -static int uli526x_init_one(struct eth_device *dev, bd_t *bis) +static int uli526x_init_one(struct eth_device *dev, struct bd_info *bis) { struct uli526x_board_info *db = dev->priv; -- cgit v1.2.3