From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- drivers/net/pcnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/net/pcnet.c') diff --git a/drivers/net/pcnet.c b/drivers/net/pcnet.c index 0928bc398b..559560860b 100644 --- a/drivers/net/pcnet.c +++ b/drivers/net/pcnet.c @@ -459,7 +459,7 @@ static void pcnet_halt_common(struct pcnet_priv *lp) } #ifndef CONFIG_DM_ETH -static int pcnet_init(struct eth_device *dev, bd_t *bis) +static int pcnet_init(struct eth_device *dev, struct bd_info *bis) { struct pcnet_priv *lp = dev->priv; @@ -495,7 +495,7 @@ static void pcnet_halt(struct eth_device *dev) pcnet_halt_common(lp); } -int pcnet_initialize(bd_t *bis) +int pcnet_initialize(struct bd_info *bis) { pci_dev_t devbusfn; struct eth_device *dev; -- cgit v1.2.3