From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- drivers/net/fec_mxc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'drivers/net/fec_mxc.c') diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 992180df86..469c7b7cef 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1102,7 +1102,7 @@ struct mii_dev *fec_get_miibus(ulong base_addr, int dev_id) #ifndef CONFIG_DM_ETH #ifdef CONFIG_PHYLIB -int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr, +int fec_probe(struct bd_info *bd, int dev_id, uint32_t base_addr, struct mii_dev *bus, struct phy_device *phydev) #else static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr, @@ -1199,7 +1199,8 @@ err1: return ret; } -int fecmxc_initialize_multi(bd_t *bd, int dev_id, int phy_id, uint32_t addr) +int fecmxc_initialize_multi(struct bd_info *bd, int dev_id, int phy_id, + uint32_t addr) { uint32_t base_mii; struct mii_dev *bus = NULL; @@ -1250,7 +1251,7 @@ int fecmxc_initialize_multi(bd_t *bd, int dev_id, int phy_id, uint32_t addr) } #ifdef CONFIG_FEC_MXC_PHYADDR -int fecmxc_initialize(bd_t *bd) +int fecmxc_initialize(struct bd_info *bd) { return fecmxc_initialize_multi(bd, -1, CONFIG_FEC_MXC_PHYADDR, IMX_FEC_BASE); -- cgit v1.2.3