From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- common/board_r.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'common/board_r.c') diff --git a/common/board_r.c b/common/board_r.c index 5e924322b2..67dc25c7d2 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -381,7 +381,7 @@ __weak int is_flash_available(void) static int initr_flash(void) { ulong flash_size = 0; - bd_t *bd = gd->bd; + struct bd_info *bd = gd->bd; if (!is_flash_available()) return 0; @@ -533,7 +533,7 @@ static int initr_api(void) #ifdef CONFIG_CMD_NET static int initr_ethaddr(void) { - bd_t *bd = gd->bd; + struct bd_info *bd = gd->bd; /* kept around for legacy kernels only ... ignore the next section */ eth_env_get_enetaddr("ethaddr", bd->bi_enetaddr); -- cgit v1.2.3