aboutsummaryrefslogtreecommitdiff
path: root/common/update.c
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2022-07-23 13:05:03 -0400
committerTom Rini <trini@konsulko.com>2022-08-04 16:18:47 -0400
commit17ead040d402c6e1fe26ac5acc4773146c8a0918 (patch)
tree9bfa97577dc86a0947a2d07b455dbd6b0638ed21 /common/update.c
parent1d3ecdac7ecd5d9b237067b0c96aa1e618c8621d (diff)
Audit <flash.h> inclusion
A large number of files include <flash.h> as it used to be how various SPI flash related functions were found, or for other reasons entirely. In order to migrate some further CONFIG symbols to Kconfig we need to not include flash.h in cases where we don't have a NOR flash of some sort enabled. Furthermore, in cases where we are in common code and it doesn't make sense to try and further refactor the code itself in to new files we need to guard this inclusion. Signed-off-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'common/update.c')
-rw-r--r--common/update.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/common/update.c b/common/update.c
index b9ad475d9d..80f16af653 100644
--- a/common/update.c
+++ b/common/update.c
@@ -20,14 +20,12 @@
#include <command.h>
#include <env.h>
-#include <flash.h>
#include <net.h>
#include <net/tftp.h>
#include <malloc.h>
#include <mapmem.h>
#include <dfu.h>
#include <errno.h>
-#include <mtd/cfi_flash.h>
#if defined(CONFIG_DFU_TFTP) || defined(CONFIG_UPDATE_TFTP)
/* env variable holding the location of the update file */
@@ -49,7 +47,8 @@
extern ulong tftp_timeout_ms;
extern int tftp_timeout_count_max;
#ifdef CONFIG_MTD_NOR_FLASH
-extern flash_info_t flash_info[];
+#include <flash.h>
+#include <mtd/cfi_flash.h>
static uchar *saved_prot_info;
#endif
static int update_load(char *filename, ulong msec_max, int cnt_max, ulong addr)